search

haf / expecto

A smooth testing lib for F#. APIs made for humans! Strong testing methodologies for everyone!
Apache License 2.0
668 stars 96 forks source link

Convert config to a DU #283

Closed AnthonyLloyd closed 5 years ago

AnthonyLloyd commented 6 years ago

This is to ensure strict binary compatibility for the API going forward.

haf commented 5 years ago

Why are we removing the Argu dependency? Seems like it works really well.

AnthonyLloyd commented 5 years ago
  1. We've had dependency problems in the past (users with different versions) where we got away with just upgrading it but possibly needed to ilmerge it. Would be good to get to no dependencies (not so far off).
  2. The maintainer has said they have little need/interest in it going forward.
  3. I'm not a fan of reflection based solutions and have some ideas how it can be done differently.
haf commented 5 years ago
  1. Upgrading the dependency is a pretty good workaround IMO; it's cheap and everyone understands it. This is similar to e.g. how the Node community works around similar issues.
  2. True, but it's also working and in use and we have the ability to push new versions of it, should it be needed. It's not holding us back, is what I'm saying. Stable, working code, in other words.
  3. Cool, let's just not throw out the baby with the bath water. ;)
AnthonyLloyd commented 5 years ago

Sure. If my experiment isn't enough of an improvement then it's not worth the risk.

AnthonyLloyd commented 5 years ago

Done in v8.9.0

auduchinok commented 5 years ago

I'm a bit late to the party but I want to say thank you so much for doing this!