Make `foldCLIArgumentToConfig` public

haf / expecto

A smooth testing lib for F#. APIs made for humans! Strong testing methodologies for everyone!

Apache License 2.0

663 stars 96 forks source link

Make `foldCLIArgumentToConfig` public #307

Closed TheAngryByrd closed 5 years ago

TheAngryByrd commented 5 years ago

With the PR from the VSTestAdapter being able to pass in configuration to Expectp, we had to copy and paste the implementation of foldCLIArgumentToConfig with tweaks to make it work. From this adapters point of view it would be nice to just leverage this function rather than having a copy. If you think this is acceptable I can do the PR.

AnthonyLloyd commented 5 years ago

I'm hoping to make ExpectoConfig internal. I'll take a look at the adapter but is it not possible to provide a list of CLiArguments to a runTests function?

TheAngryByrd commented 5 years ago

Oh you're thinking runTestsWithCLIArgs? I overlooked that. I think that would work just fine 👍

AnthonyLloyd commented 5 years ago

cool