haf / expecto

A smooth testing lib for F#. APIs made for humans! Strong testing methodologies for everyone!
Apache License 2.0
663 stars 96 forks source link

Expose FsCheck Check.Verbose or introduce Every and EveryShrink in FsCheckConfig #329

Open da9l opened 5 years ago

da9l commented 5 years ago

When learning FsCheck I've found it useful to be able to run a property with Check.Verbose as opposed to Check.One.

I see that FsCheckConfig is mapped to a FsCheck.Config but the Every and EveryShrink functions (that are used in Check.Verbose) are set to fun -> String.Empty.

Is there a better way to accomplish this that I've missed? Or would this be the way forward to implement support for Check.Verbose?

AnthonyLloyd commented 5 years ago

Yes it looks like Every and EveryShrink could be based on a property on FsCheckConfig. Or maybe it could be based on the Verbosity of the ExpectoConfig.

da9l commented 5 years ago

Yeah, the Every and EveryShrink are pretty generic and the Check.Verbose sets a specific implementation. In the Expecto-FsCheck integration would it be sufficient if the ExpectoConfig verbosity setting results in a specific implementation too?

AnthonyLloyd commented 5 years ago

I would think so.