haf / expecto

A smooth testing lib for F#. APIs made for humans! Strong testing methodologies for everyone!
Apache License 2.0
663 stars 96 forks source link

Report duplicated test names via printer #339

Closed auduchinok closed 4 years ago

auduchinok commented 4 years ago

Fixes #336.

haf commented 4 years ago

Have you validated this on a terminal, so that it doesn't mess up e.g. the console/ANSI escape codes?

auduchinok commented 4 years ago

Nope, only run the test suite via fake. Isn't it something that should be covered by the printers (already)?

haf commented 4 years ago

@auduchinok It is, but I never got around to proving that property in my head, because there's a certain amount of global state when printing (-ansi) to the console singleton. In all likelyhood, it's enough for you to run expecto with itself through its test suite on your terminal and see that it works.

haf commented 4 years ago

@auduchinok thank you for your contribution!