search

haf / expecto

A smooth testing lib for F#. APIs made for humans! Strong testing methodologies for everyone!
Apache License 2.0
663 stars 96 forks source link

Get inner message from exception #349

Closed MNie closed 4 years ago

MNie commented 4 years ago

Related to #348 . I have 2 questions:

  1. All places that should be changed are covered here?
  2. Checking if InnerException is right, or we prefer <> null?

CC: @haf

haf commented 4 years ago

I think we should focus on just solving the issue since changing it for the teamcity printer might have unintended consequences unless verified, such as having the message halfed due to the newline; TeamCity parses single lines into its messages.

Do we separate out the printing to its own private function for now?

haf commented 4 years ago

Thank you for your PR @MNie ! This is what we need :)

MNie commented 4 years ago

@haf

haf commented 4 years ago

@MNie Excellent, thank you!