haf / expecto

A smooth testing lib for F#. APIs made for humans! Strong testing methodologies for everyone!
Apache License 2.0
663 stars 96 forks source link

Add command-line option to generate XML test report. #374

Closed teo-tsirpanis closed 4 years ago

teo-tsirpanis commented 4 years ago

This PR:

The removal of the Expecto.TestResults assembly might be a breaking change, but I believe its introduction is totally justifiable, given how easy it will become to generate test reports without code changes.

haf commented 4 years ago

Well, it all looks great, like always when you're hacking away.

haf commented 4 years ago

Did you manage to keep all public surface areas the same?

teo-tsirpanis commented 4 years ago

Did you manage to keep all public surface areas the same?

Yes, I did. The only thing I removed was a misspelled identifier named depricated (had no reason to exist, and it had already been marked as obsolete).

Given that this change is going to be pushed for a major version bump, I am going to entirely remove the existing API to generate test results; it is already exposed via the more uniform CLIArgs.

haf commented 4 years ago

I am going to entirely remove the existing API to generate test results

Ok, so this is WIP still?

teo-tsirpanis commented 4 years ago

Yes.

teo-tsirpanis commented 4 years ago

It's ready.

haf commented 4 years ago

@teo-tsirpanis thank you! I'll try release tonight

teo-tsirpanis commented 4 years ago

Good, but a new major version? That fast? I think a minor version increase (8.14.0) is more appropriate. Unless you don't have any reservation with major version releases (like me).

And don't forget to mark the Expecto.TestResults package as deprecated.

If you make it a major version increase eventually, it would be better to wait as I am working to fix #328 (which is also tagged with semver-MAJOR).

haf commented 4 years ago

Sure, I have no problem delaying, but part of the contract with IDEs and users is that we don't break even the slightest thing in between minors :)