haf / expecto

A smooth testing lib for F#. APIs made for humans! Strong testing methodologies for everyone!
Apache License 2.0
663 stars 96 forks source link

F# 5 String Interpolation Causes Spurrious Test Failures #424

Closed Gastove closed 2 years ago

Gastove commented 2 years ago

If a method under test uses F# 5 string interpolation (e.g. sprintf $"{myVar}"), the test will throw a method not found error and fail, whether the actual outcome of the test was a failure. This is due to Expecto pinning F# Core 4 in its paket.dependencies.

I've forked the project, updated the F# Core version to 5.0.2, and run both the build and the test suite; both pass with no errors. I'm very happy to PR that change, but I wanted to ask first: are there any other checks, build steps, or other things I should verify to make sure the change is safe? Very happy to help however I can.

Thanks so much for Expecto! It really is a delight to use.