search

haf / expecto

A smooth testing lib for F#. APIs made for humans! Strong testing methodologies for everyone!
Apache License 2.0
663 stars 96 forks source link

Bump minimum target framework #447

Closed ratsclub closed 1 year ago

ratsclub commented 1 year ago

This PR bumps the minimum target framework to the current LTS. This makes it possible to use Tasks.

ratsclub commented 1 year ago

As far as I can tell, yes. It does use %A... Is there a better approach here?

ratsclub commented 1 year ago

@baronfel @haf this is building, do you think this is good enough? My idea is to tackle as much issues as possible (such as #446 and #383) and release a new major with the breaking changes.

1eyewonder commented 1 year ago

Would this also be a fix to this issue as well? #440

ratsclub commented 1 year ago

@1eyewonder This PR bumps the dependency, so I would say yes.

haf commented 1 year ago

👍

ratsclub commented 1 year ago

@haf This is ready for review. Do you think that I should change anything else here?

haf commented 1 year ago

Looks great