Open xperiandri opened 1 year ago
It makes sense to me at a high level, but I don't know enough about the original motivations for using a custom logger.
I would guess because Microsoft.Extensions.Logging did not exist when Expecto was first built. That, and I can definitely understand wanting to dogfood Logary. @haf is that accurate?
Regardless I also think this is a good idea. I'm usually using MEL ILogger in my own code under test anyway, so I have to use an adapter from the Expecto logger -> ILogger. If Expecto used ILogger directly, I'd be able to remove these adapters. Expecto could also use FSharp.Logf to keep the FSharp-y semantics.
Yes, accurate.
Would Logary also need to implement ILogger
to keep the default behavior?
I propose rewriting the logging stack to the standard
Microsoft.Extensins.Logging
andILogger
class usage to be consistent and support structural logging. Please approve if you agree.