haf / expecto

A smooth testing lib for F#. APIs made for humans! Strong testing methodologies for everyone!

Apache License 2.0

663 stars 96 forks source link

Fix immediate task execution when defining test cases #492

Closed farlee2121 closed 3 months ago

farlee2121 commented 3 months ago

I.e. testTask and testCaseTask would start the task as soon as the test definition is created instead of when the test suite is run. This fixes a breaking change from how testTask used to work and a flaw of the new testCaseTask api. It is a breaking change to the testCaseTask api.

Thanks to @TheAngryByrd for noticing this issue on pr

484

farlee2121 commented 3 months ago

My thought is to release this as 10.2.1 and deprecate the 10.2.0 packages. This release isn't backwards compatible with 10.2.0, but it fixes a backwards compatibility issue introduced by 10.2.0 and only breaks compatibility with endpoints introduced in that same release.

Thoughts?

TheAngryByrd commented 3 months ago

My thought is to release this as 10.2.1 and deprecate the 10.2.0 packages. This release isn't backwards compatible with 10.2.0, but it fixes a backwards compatibility issue introduced by 10.2.0 and only breaks compatibility with endpoints introduced in that same release.

Thoughts?

Yeah I think that's a reasonable approach vs just bumping major.

farlee2121 commented 3 months ago

New version is out, 10.2.0 is deprecated with an explanatory message

TheAngryByrd commented 3 months ago

Thank you!!