hafarooki / ExplosionReversal

A lightweight plugin for Minecraft servers which makes blocks destroyed by explosions regenerate.
MIT License
8 stars 7 forks source link

Add block by block placement option #1

Closed hafarooki closed 4 years ago

hafarooki commented 6 years ago

Likely implemented by assigning a random delay to each block on explode for additional regeneration delay, configurable

olekristian commented 6 years ago

+1

BornToDoStuff commented 4 years ago

+1

this is vital to avoid suffocating players and mobs when the blocks regen.

rsammelson commented 4 years ago

+1

hafarooki commented 4 years ago

I will look into implementing this after finals

rsammelson commented 4 years ago

What I added is not quite block by block, but it is based on distance, placing layers of blocks at a time.

hafarooki commented 4 years ago

Thanks to @rsammelson for his PR which essentially makes it place it cubic layer by later, kind of like block by block placement but the pieces fall back in place in style, Buzz Light-year would be proud.

I will try to make this available on Spigot and GitHub releases soon, got an exam and a partial project submission due tomorrow and a lot of homework due short after that, plus some work to catch up on, so it might be sometime this weekend.

BornToDoStuff commented 4 years ago

Wondering what the status of this one is because I am excited for it. No rush, I know you have school and that comes first, but I am eagerly waiting for when you get time to push out this update.

hafarooki commented 4 years ago

tbh looking like it won't be till summer, sorry

On Wed, Apr 22, 2020, 4:14 PM BornToDoStuff notifications@github.com wrote:

Wondering what the status of this one is because I am excited for it. No rush, I know you have school and that comes first, but I am eagerly waiting for when you get time to push out this update.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicleBrick%2FExplosionRegen%2Fissues%2F1%23issuecomment-618014930&data=02%7C01%7C%7C341825bd0a13464fde9f08d7e6f9c5cf%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637231832746724075&sdata=QY76ZTqDa9K%2BmYOeWZ7cvw%2B%2BC6LV%2FI0%2FQuA9AJLwuQI%3D&reserved=0, or unsubscribe https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABQHXNLRWUFVYEML6V333UTRN5F2TANCNFSM4FRUJLMA&data=02%7C01%7C%7C341825bd0a13464fde9f08d7e6f9c5cf%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637231832746724075&sdata=RD1kt2%2FVOIwHPQQaPb81qpVyVEXh9GDuR9CroVCJ8sE%3D&reserved=0 .

rsammelson commented 4 years ago

@MicleBrick what do you need to do in order to release this?

hafarooki commented 4 years ago

just need to test it and release it, takes time tho. There's only a few weeks left anyway, shouldn't be too much longer

On Wed, Apr 22, 2020, 4:53 PM Robby Sammelson notifications@github.com wrote:

@MicleBrick https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicleBrick&data=02%7C01%7C%7Ce872a720cf8c45172b0608d7e6ff3f99%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637231856262631291&sdata=V%2FQCYdXJaicU6rsuAj9G%2FXolta%2Bbk1yTHg4G28m%2BMHA%3D&reserved=0 what do you need to do in order to release this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicleBrick%2FExplosionRegen%2Fissues%2F1%23issuecomment-618034699&data=02%7C01%7C%7Ce872a720cf8c45172b0608d7e6ff3f99%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637231856262641281&sdata=PTEhaICq89H4RpNJIsN%2FhTSXpN%2F3ixux%2BCZY4p0yZoA%3D&reserved=0, or unsubscribe https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABQHXNKLEOJJYOQ6FIDSA53RN5KNRANCNFSM4FRUJLMA&data=02%7C01%7C%7Ce872a720cf8c45172b0608d7e6ff3f99%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637231856262641281&sdata=FatQRrmPpk68NJw%2BvYJBEa75g3YyfURur8LQsK%2FHBWQ%3D&reserved=0 .

BornToDoStuff commented 4 years ago

I am available to help you bug test this whenever you are able to get this feature pushed out! Once this and issue #11 are resolved I will be installing this plugin almost immediately on my server.

hafarooki commented 4 years ago

I'm actually planning on doing it later today. thanks for the offer but I should be able to test it myself.

hafarooki commented 4 years ago

actually forgot to do it cause i got caught up with other stuff lol, sorry. i'll do it right after work today

BornToDoStuff commented 4 years ago

This works, and is a good start. However the main reason to do this is to keep players and mobs from getting trapped inside the explosion regen zone and dieing of suffocation. Right now it looks cool, but the blocks seem to regen from closest to the point of explosion to the farthest away from the explosion which almost always ends with anything inside a creeper, ghast, or wither "pit" suffocating because the "ceiling" regenerates before the "floor". This also means anything with gravity that WAS on the surface is now buried and/or glitched under the ground (for example as per #14 armor stands are now regened but sometimes fall into the ground because the blocks they were on did not come back yet). To make this a more useful feature the blocks need to regenerate in a specific order. From the inside out. Farthest from impact to closest to impact in other words. Additionally, the timing set in the config is either unclear or incorrect as when I time it the blocks begin to regen at approximately 24 seconds and finish at around 30 seconds when regen delay is set to 1.0 (meaning there should be an entire minute before they even start regenerating, and they finish in half of that). If this is intended then the config should be more clear but I believe this is an error.

hafarooki commented 4 years ago

Pls open new issues for those suggestions/bugs