hafarooki / ExplosionReversal

A lightweight plugin for Minecraft servers which makes blocks destroyed by explosions regenerate.
MIT License
8 stars 7 forks source link

Add Block Placement based on Distance #18

Closed rsammelson closed 4 years ago

rsammelson commented 4 years ago

This adds a function to place blocks based on distance. Distance is measured using taxicab distance (xDistance + yDistance + zDistance). Blocks at distance 16 are placed after regenDelay minutes, while blocks closer or farther are adjusted by distance * distanceDelay seconds. This fixes #1.

hafarooki commented 4 years ago

Have you tested this with tile entities like signs and such?

rsammelson commented 4 years ago

I haven’t, so I will, but as this does not modify the interaction with the object in any way, only with the entity/block exploding and the time that it exploded, it shouldn’t have any effect.

rsammelson commented 4 years ago

I just tested it with signs, and it works normally. They still have the previously existing bug that any text on them is wiped out.

hafarooki commented 4 years ago

How long has that bug existed? Last time I tested it signs worked fine... Does it always happen or only in certain situations? Wall and standing or both?

rsammelson commented 4 years ago

It happens to standing and wall signs. The angle of standing signs is kept. It happened on the first version I tested, which was 2.5, and I don’t think that I made any modifications. See #11, it might be connected.

hafarooki commented 4 years ago

I see. Thank you for all of this, I'll see if I can figure it out when my semester ends. I'll merge this now and test it/update the spigot page when I get a chance.