Closed weiyunna closed 7 years ago
is it accepted in github?
I've been away. I'll merge this into the package in the next few days.
That's great!Thank you very much!
Thanks! Added as china_prov_grid1
.
Taiwan should be added into the China map.
Today, I check the grid names in geofacet package, however, I do not find china_prov_grid1 you added.
@lijianguo531 sorry about that I just grabbed a map I found online without much thought. If you can provide a map reference image that looks good that would be great.
The grid is in the package. In short, you need to reinstall the package from github to get the new grid. In theory you shouldn't need to reinstall and it would still find the grid and grab it from the web (but the grid wouldn't show up in get_grid_names()
since that only checks locally-installed grids) but there is a bug in that code that I have fixed and need to submit to CRAN.
this is China Grid Map
Grid data: