search

hafen / rminiconda

Install and maintain isolated miniconda Python installations from R
Apache License 2.0
67 stars 4 forks source link

rappdirs support #3

Open hrbrmstr opened 5 years ago

hrbrmstr commented 5 years ago

Documentation and functionality change to get_miniconda_path() to look first in the R_MINICONDA_PATH then does the rappdirs check and finally ~/rminiconda check (both for existence, then tries to create if not there and then tests if writeable).

I need to test this when I get bandwidth (hotel wifi is as bad as Stanford's guest network) but wanted to get it submitted before 🛩.

hafen commented 5 years ago

Thanks! It looks like the linux and windows CI tests passed. Testing locally on MacOS, I get an error due to the space in "Application Support" when miniconda installs. Probably need to escape the space in the path when running the installer (https://github.com/hrbrmstr/rminiconda/blob/master/R/rminiconda.R#L48). This of course was already a bug if the user had supplied a path with spaces.

hafen commented 5 years ago

Just an update on this - the space in "Application Support" looks like it is an issue out of our control as the miniconda installer won't allow spaces in paths, which makes it difficult to work with rappdirs.