hafen / trelliscopejs

TrelliscopeJS R Package
https://hafen.github.io/trelliscopejs
Other
263 stars 36 forks source link

Error in as.Date.numeric(value) : 'origin' must be supplied #42

Closed dennet closed 7 years ago

dennet commented 7 years ago

First of all, love the package! An awesome tool! Thanks a lot.

After the latest update I'm getting the following error when my x-asis is a Date type variable: Error in as.Date.numeric(value) : 'origin' must be supplied

Simple code example:

library(tidyverse)
library(trelliscopejs)

economics_long %>% 
    ggplot(aes(date, value)) +
    geom_line() +
    facet_trelliscope(~variable)
hafen commented 7 years ago

Thanks for the report. In the latest version there were some updates for allowing you to specify scales for ggplot faceting (and the default is now for all axes to have the same limits as it should be) and there is some computation in the background to set these. Can you provide a reproducible example (provide a "dummy" data set that reproduces the error)?

@schloerke can you look into this?

dennet commented 7 years ago

Thank you for looking into it. The snippet I've shared should be reproducible; economics_long dataset is part of ggplot2.

hafen commented 7 years ago

Oops I should have realized that :). Thanks.

schloerke commented 7 years ago

Fixed in #43

dennet commented 7 years ago

thank you, guys! really appreciate the quick turnaround!

asad-taj commented 6 years ago

I am still facing the same issue

hafen commented 6 years ago

Can you provide an example? The originally-provided example is now working with the fix in #43.