Closed lmbramer closed 5 years ago
Thanks for submitting this. I have fixed this so that it doesn't fail. However, when someone uses cog()
inside data.frame()
when adding a cognostics column and doesn't specify stringsAsFactors = FALSE
, any custom cognostics attributes (such as the description) will be lost. I have added a note when such a case is detected. It's probably best to just use tibble()
instead of data.frame()
.
When I try to use map_cog to add a data.frame of cognostics, a call to building the trelliscope display errors out:
I get the following error:
It seems that
bind_cog_list_and_descs
is attempting to pull column attributes for each cognostic from a single row, and update the attributes of the result of callingbind_rows
on the list of cognostics. However, factor variables don't seem to retain any attributes whenbind_rows
is called.