hafenkran / duckdb-bigquery

Integrates DuckDB with Google BigQuery, allowing direct querying and management of BigQuery datasets
MIT License
58 stars 3 forks source link

Support for DuckDB v1.1.0 #21

Closed carlopi closed 1 month ago

carlopi commented 2 months ago

Writing to notify that at this moment in time this extension do not successfully build or test against duckdb v1.1.0.

I am writing to inform you that the extension keep being available on duckdb v1.0.0, but can't be distributed on v1.1.0 until the problem is sorted out.

Problem, as detected by the build infrastructure is as follow: https://github.com/duckdb/community-extensions/actions/runs/10619930977/job/29438634772#step:15:4420, and looks to require to adapt to some duckdb-level API changes

In file included from /Users/runner/work/community-extensions/community-extensions/src/storage/bigquery_insert.cpp:17:
Error: /Users/runner/work/community-extensions/community-extensions/src/include/storage/bigquery_insert.hpp:47:12: error: virtual function 'ParamsToString' has a different return type ('string' (aka 'basic_string<char>')) than the function it overrides (which has return type 'InsertionOrderPreservingMap<string>' (aka 'InsertionOrderPreservingMap<basic_string<char>>'))
    string ParamsToString() const override;
    ~~~~~~ ^
/Users/runner/work/community-extensions/community-extensions/duckdb/src/include/duckdb/execution/physical_operator.hpp:64:46: note: overridden virtual function is here
        virtual InsertionOrderPreservingMap<string> ParamsToString() const {
                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
1 error generated.
[317/509] Building CXX object src/common/CMakeFiles/duckdb_common.dir/ub_duckdb_common.cpp.o
[318/509] Building CXX object src/core_functions/aggregate/holistic/CMakeFiles/duckdb_aggr_holistic.dir/ub_duckdb_aggr_holistic.cpp.o
ninja: build stopped: subcommand failed.

If you can use assistance, please circle back on this.

More information / example of what other extension needed to change at https://github.com/duckdb/community-extensions/issues/85.

Thanks for being involved with the duckdb community extensions!

hafenkran commented 1 month ago

Hey @carlopi, thanks for the heads-up and sorry for the late response! I was a bit tied up and unavailable over the last couple of weeks, but I’m already on it now and looking into the issue. I’ll circle back once I have rolled out the fix or need any further clarification.

Appreciate the detailed breakdown and the link!