search

hafs-community / HAFS

Hurricane Analysis and Forecast System
Other
37 stars 57 forks source link

Update submodule hafs_graphics.fd/hrd_gplot #172

Closed ghassan-alaka closed 1 year ago

ghassan-alaka commented 1 year ago

Description of changes

This PR brings the latest upgrades, fixes, and other modifications from HRD's GPLOT graphics package into the HAFS-Community develop branch. The functionality has been extensively tested in the HAFS workflow by HRD employees (@ghassan-alaka @AndrewHazelton @lgramer) and will further stabilize the hrdgraphics task.

Dependencies (optional)

The HAFS-Community fork of GPLOT was successfully updated and can be found here: - hafs-community/GPLOT/pull/11

Contributors (optional)

Extensive testing and upgrades were performed by @AndrewHazelton, @lgramer, and Mu-Chieh Ko at HRD. A big thanks to @BinLiu-NOAA who has guided us through the merge process.

Tests conducted

Extensive testing on Jet, Hera, and Orion. This package will NOT run on WCOSS2 due to issues with deprecated and/or unavailable software on that machine.

Application-level regression test status

N/A

BinLiu-NOAA commented 1 year ago

@ghassan-alaka, PR #171 is merged. Please sync this PR branch with the latest HAFS develop branch. Thanks! Meanwhile, there is no HAFS application/workflow level regression tests using hrd graphics yet. So, we will not need conduct regression tests for this PR.

ghassan-alaka commented 1 year ago

@BinLiu-NOAA I think this PR is almost ready to be merged. Within the hafs-community/gplot repository, all changes were merged into the support/HAFS branch. Two key updates to this PR today: 1) updated .gitmodules to point to the correct GPLOT submodule branch 2) committed the updated GPLOT files under _./sorc/hafs_graphics.fd/hrdgplot

I am requesting that @AndrewHazelton or @lgramer conduct a test of this updated support/HAFS branch within the HAFS workflow. It should behave exactly as the feature/realtime2022 branch, but it would be good to be sure that nothing unexpected occurred during the merge.