hafs-community / HAFS

Hurricane Analysis and Forecast System
Other
37 stars 57 forks source link

Point to the latest GPLOT `support/HAFS` branch #211

Closed ghassan-alaka closed 1 year ago

ghassan-alaka commented 1 year ago

Description of changes

Update the GPLOT submodule (hafs_graphics.fd/hrd_gplot) and .gitmodules file to point to the latest release/0.4.0 branch. The branch is forked here: https://github.com/hafs-community/GPLOT/tree/release/0.4.0

Contributors (optional)

@lgramer @AndrewHazelton

Tests conducted

Extensive testing on Orion, Hera, and Jet.

Application-level regression test status

Running the HAFS application-level regression tests is currently performed by code reviewers after the developer creates the initial PR. As regression tests are conducted, the testers should use the checklist below to indicate successful regression tests. You may add other tests as needed. If a test fails, do not check the box. Instead, describe the failure in the PR comments, noting the platform where the test failed.

BinLiu-NOAA commented 1 year ago

@ghassan-alaka, just quickly check with you, do you meant to merge this PR back to HAFS develop branch or the support/hafs.v1.1.0 branch (the real-time parallel experiment branch)?

ghassan-alaka commented 1 year ago

This is a good question for @AndrewHazelton . It should definitely go into develop to carry it forward to future developments. However, if Andy is using support/hafs.v1.1.0 then these updates should also be merged into that branch as well.

AndrewHazelton commented 1 year ago

Right, I think it would be good to have it in both.

On Wed, Jul 26, 2023 at 2:36 PM GusAlaka-NOAA @.***> wrote:

This is a good question for @AndrewHazelton https://github.com/AndrewHazelton . It should definitely go into develop to carry it forward to future developments. However, if Andy is using support/hafs.v1.1.0 then these updates should also be merged into that branch as well.

— Reply to this email directly, view it on GitHub https://github.com/hafs-community/HAFS/pull/211#issuecomment-1652457901, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMCUFFDCAC3IUZH4MDZJNF3XSF5VDANCNFSM6AAAAAA2W3BRGA . You are receiving this because you were mentioned.Message ID: @.***>

ghassan-alaka commented 1 year ago

@BinLiu-NOAA The .gitmodules file has been updated. It now points to the support/HAFS branch of the GPLOT submodule.

BinLiu-NOAA commented 1 year ago

@BinLiu-NOAA The .gitmodules file has been updated. It now points to the support/HAFS branch of the GPLOT submodule.

Thanks, @ghassan-alaka! One more thing, could you please also update the submodule to point the latest commit of the support/HAFS branch? https://github.com/hafs-community/GPLOT/commit/f1d8e2671d7ad0ea229596b5c7541538d0135ba9

BinLiu-NOAA commented 1 year ago

Any way, I have just updated to point to the latest commit of the support/HAFS branch (https://github.com/hafs-community/GPLOT/commit/f1d8e2671d7ad0ea229596b5c7541538d0135ba9)