hafs-community / HAFS

Hurricane Analysis and Forecast System
Other
29 stars 54 forks source link

Improve the hafs_obs_prep job script to handle zero bytes gfs.tCCz.prepbufr file #244

Open BinLiu-NOAA opened 9 months ago

BinLiu-NOAA commented 9 months ago

Description

Provide a clear and concise description of the requested feature/capability. From NCO SPA: In the HAFS v1.0 IT tests, tested the hafs_obs_prep job with a gfs.tCCz.prepbufr file with zero bytes. Expected the job should failed with error message, similar as HWRF jhwrf_bufrprep job, “CRITICAL: HWRF bufrprep is aborting: gfs.t00z.prepbufr: is non-existant or empty”. But the hafs_obs_prep job proceeded with failure nor error message.

Please look into this at the next upgrade to improve the hafs_obs_prep job to properly check and fail when the gfs.tCCz.prepbufr file has zero bytes.

Proposed solution

How should the new feature/capability be added? If you have thoughts on the implementation strategy, please share them here.

Status (optional)

Do you (or a colleague) plan to work on adding this feature?

Related to (optional)

Directly reference any related issues or PRs in this or other repositories, and describe how they are related. Examples:

BinLiu-NOAA commented 5 months ago

Updated exhafs_obs_prep.sh so that it checks if the gfs prepbufr file exists and is non-empty, otherwise it exits with a "FATAL ERROR" (see ed0d888).