search

hafs-community / HAFS

Hurricane Analysis and Forecast System
Other
38 stars 57 forks source link

code stability test failed in exec/hafs_obs_preproc.x #245

Open BinLiu-NOAA opened 11 months ago

BinLiu-NOAA commented 11 months ago

Description

Provide a clear and concise description of the requested feature/capability. From NCO SPA: During the HAFS v1.0 code stability test, to recompile HAFS code with ‘-check all’ and ‘-ftrapuv’ flag, or using "-check bounds" only.

The code stability test of exec/hafs_obs_preproc.x failed in either with ‘-check all’ or "-check bounds". Please investigate this failure and address it at the next upgrade.

Here are the detailed info - /lfs/h1/ops/test/packages/hafs.v1.0.3/sorc.chkall - builds with '-check all' /lfs/h1/ops/test/packages/hafs.v1.0.3/exec.chk.all - exec with '-check all'/lfs/h1/ops/test/packages/hafs.v1.0.3/sorc.chk.bounds - builds with '-check bounds' /lfs/h1/ops/test/packages/hafs.v1.0.3/exec.chk.bounds - exec with '-check bounds'

lfs/h1/ops/test/output/20230613/hfsa1_obs_prep_00_NHC_09L_IAN_2022092400.o63086750 obs_prep/tempdrop/hafs_obs_preproc.out - forrtl: error (65): floating invalid Image PC Routine Line Source hafs_obs_preproc. 00000000006FE86B Unknown Unknown Unknown libpthread-2.31.s 000014AF072EC8C0 Unknown Unknown Unknown libimf.so 000014AF0793CAE1 __libm_log_l9 Unknown Unknown hafs_obs_preproc. 000000000059BE42 meteo_methods_int 116 meteo_methods_interface.F90 hafs_obs_preproc. 00000000006703DC sonde_tempdrop_in 686 sonde_tempdrop_interface.F90 hafs_obs_preproc. 000000000069E926 sonde_tempdrop_in 1758 sonde_tempdrop_interface.F90 hafs_obs_preproc. 0000000000661C61 sonde_tempdrop_in 121 sonde_tempdrop_interface.F90 hafs_obs_preproc. 00000000006A36F2 observations_inte 162 observations_interface.F90 hafs_obs_preproc. 00000000006A3596 observations_inte 74 observations_interface.F90 hafs_obs_preproc. 00000000006A37E1 obs_preproc_inter 78 obs_preproc_interface.F90

Proposed solution

How should the new feature/capability be added? If you have thoughts on the implementation strategy, please share them here.

Status (optional)

Do you (or a colleague) plan to work on adding this feature?

Related to (optional)

Directly reference any related issues or PRs in this or other repositories, and describe how they are related. Examples:

BijuThomas-NOAA commented 10 months ago

Three float invalid errors were noticed with the debug build run on WCOSS2. Working with Henry to fix the issues One is involved with dew point calculation where negative values of RH are inputted. Another one is related to the bufr library.

BijuThomas-NOAA commented 10 months ago

@ZhanZhang-NOAA Do you know when NCO does the stability test(09L_IAN_2022092400), Is it a warm start or just a cold start for the 2022092400 cycle?

ZhanZhang-NOAA commented 10 months ago

@BijuThomas-NOAA I don't know remember if he did test with cold or warm start. However, since it failed at hafs_obs_preproc.x step, cold/warm-start should not matter.

BijuThomas-NOAA commented 10 months ago

Two floating invalid errors with debug build are fixed in:

A third floating invalid error(debug coming from NCEPLIBS-bufr/ipks.f @BinLiu-NOAA : Should we open an issue at https://github.com/NOAA-EMC/NCEPLIBS-bufr ?

BijuThomas-NOAA commented 9 months ago

The float invalid issue with NCEPLIBS-bufr/ipks.f is fixed(upgraded bufr/12.0.0 from bufr/11.7.0). The executable hafs_obs_preproc.x passed the code stability tests.

BijuThomas-NOAA commented 7 months ago

Fixing a division by zero in math_methods_interface.F90 and taking th… …e log of a negative RH in meteo_methods_interface.F90, which was noticed in Debug buildhttps://github.com/hafs-community/HAFS/commit/7f5f7091c184125d3c6b9f54d6da624e564007f3