search

hafs-community / HAFS

Hurricane Analysis and Forecast System
Other
29 stars 54 forks source link

code stability test failed in exec/hafs_vi_split.x #250

Open BinLiu-NOAA opened 9 months ago

BinLiu-NOAA commented 9 months ago

Description

Provide a clear and concise description of the requested feature/capability. From NCO SPA: During the HAFS v1.0 code stability test, to recompile HAFS code with ‘-check all’ and ‘-ftrapuv’ flag, or using "-check bounds" only.

The code stability test of exec/hafs_vi_split.x and exec/hafs_vi_anl_combine.x failed in "-check bounds". Please investigate this failure and address it at the next upgrade.

Here are the detailed info - /lfs/h1/ops/test/packages/hafs.v1.0.3/sorc.chkall - builds with '-check all' /lfs/h1/ops/test/packages/hafs.v1.0.3/exec.chk.all - exec with '-check all'/lfs/h1/ops/test/packages/hafs.v1.0.3/sorc.chk.bounds - builds with '-check bounds' /lfs/h1/ops/test/packages/hafs.v1.0.3/exec.chk.bounds - exec with '-check bounds'

Failed with '-check bounds' - /lfs/h1/ops/test/output/20230612/hfsa1_atm_vi_00_NHC_09L_IAN_2022092400.o62814040, hfsa1_atm_vi_fgat03_00_NHC_09L_IAN_2022092400.o62813956, hfsa1_atm_vi_fgat09_00_NHC_09L_IAN_2022092400.o62814200, hfsa1_atm_vi_fgat06_00_NHC_09L_IAN_2022092400.o62813963 forrtl: error (65): floating invalid Image PC Routine Line Source hafs_vi_split.x 00000000005DCDBB Unknown Unknown Unknown libpthread-2.31.s 00001542837CA8C0 Unknown Unknown Unknown hafs_visplit.x 000000000058C1ED wnlsm 754 WNLSM.f90 hafs_visplit.x 000000000059043D wnnls 405 WNNLS.f90 hafs_visplit.x 0000000000575676 separ 135 SEPAR.f90 hafs_vi_split.x 00000000004CABC6 hurrmove 2549 split.f90 hafs_vi_split.x 0000000000490026 wrfmove 1618 split.f90

/lfs/h1/ops/test/output/20230612/hfsa1_atm_vi_fgat03_00_NHC_09L_IAN_2022092400.o62827330 hfsa1_atm_vi_fgat09_00_NHC_09L_IAN_2022092400.o62827332, hfsa1_atm_vi_00_NHC_09L_IAN_2022092400.o62827329 obs psfc_obs,PMN06= 100500.0 -999.0000
VMX06,vobs= NaN 18.00000
forrtl: error (65): floating invalid Image PC Routine Line Source hafs_vi_anl_combi 0000000000578A1B Unknown Unknown Unknown libpthread-2.31.s 000014810252A8C0 Unknown Unknown Unknown hafs_vi_anl_combi 000000000042DBE1 MAIN__ 654 anl_combine.f90

Proposed solution

How should the new feature/capability be added? If you have thoughts on the implementation strategy, please share them here.

Status (optional)

Do you (or a colleague) plan to work on adding this feature?

Related to (optional)

Directly reference any related issues or PRs in this or other repositories, and describe how they are related. Examples:

BinLiu-NOAA commented 8 months ago

@ChuankaiWang-NOAA, could you please work with @BijuThomas-NOAA to reproduce this issue and then address this issue? Thanks!

ChuankaiWang-NOAA commented 8 months ago

An uninitialized variable was found in the WNLSM.f90. Two uninitialized variables were found in the anl_combine.f90. The VI process completed successfully with debug built (-check all -ftrapuv) after initializing those three variables. Both results from the new codes and the results from the original codes are identical. The updated codes were in the hafsv2_baseline_nco branch.