search

hagabbar / matching_cnn_paper

Matching matched filtering with deep learning in gravitational-wave astronomy
2 stars 1 forks source link

Marco: is the cyan curve whitened in figure 1? #41

Closed Fergus-Hayes closed 6 years ago

Fergus-Hayes commented 6 years ago

The caption of figure 1 reads: " A whitened noise-free time series of a BBH signal (cyan) with component masses..." Is the cyan curve really whitened?

mj-will commented 6 years ago

I've checked the code and the signal (cyan curve) is whitened before plotting. But I'll do some further checks to be sure.

mj-will commented 6 years ago

Replotted the waveform with the modified whitening function Chris sent. Will upload a .pdf version to the repository when we're clear on the issues with the windowing.

waveform

mj-will commented 6 years ago

Uploaded the updated pdf version and Chris verified that waveform is correctly whitened.