hagabbar / matching_cnn_paper

Matching matched filtering with deep learning in gravitational-wave astronomy
2 stars 1 forks source link

Tom: Better explanation of SNR used #48

Closed Fergus-Hayes closed 6 years ago

Fergus-Hayes commented 6 years ago

From line 149 onwards there doesn't seem to be any mention of what SNR the training injections were made with. It just says 'predefined optimal SNR' but not the actual value(s). Later in the paper there seem to be various 'experiments' with rho_opt = 2,4,6,8,10,12 - does this mean that the NN was trained differently for each experiment with that specific rho_opt value? This is not clear.

Fergus: I feel this is not explained badly in the paper as it is. Maybe though we should include some mention of the varying SNR datasets we used when in the 'simulation details' section.