haganbmj / MagicSetEditor2

Magic Set Editor is a program for designing trading cards
Other
17 stars 7 forks source link

fix: apply image scale after slice window to avoid mask issues #15

Closed haganbmj closed 2 years ago

haganbmj commented 2 years ago

unknown

This is just me not knowing that MSE applies masks on the Image Slice Window. When it does it expects the mask and the target_size to match. Rather than changing how the mask is drawn it's easer (and cleaner) to just apply the internal scale when the file is ready to be saved. The rescaling isn't applied until the very end, so it's easy enough to just hook into that and do it as the very last operation. I think I also see now how I'd want to go about doing "as big as possible" if I want to apply that. I think there might still be some concerns around sharpening, but that's probably just an acceptable issue. It might also be worth moving the internal selector to this window since it doesn't necessarily need to be static for all cards.