usage of undefined variable x.rows

haganjam / InvTraitR

Pipeline to assign biomass-length allometry equations to a taxonomic name based on taxonomic hierarchy and geographic (or environmental) proximity

Other

3 stars 0 forks source link

usage of undefined variable x.rows #9

Closed black-snow closed 1 year ago

black-snow commented 1 year ago

https://github.com/haganjam/FW_invert_biomass_allometry/blob/1dffeb74f3a874c7d8954852690c692b2786f3a1/R/clean_taxon_names.R#L149

x.rows is undefined there - did we forget it when we did some refactoring?

P. S.: Why's bdc creating those nasty Output dirs? Super annoying - gonna open an issue there :D

haganjam commented 1 year ago

I sorted out the x.rows problem. Yes, we (I) didn't properly commit my changes. Fixed now. Yeah... The Output folder. I just delete it in a line of code but that's obviously a sub-optimal solution. I'll look into it.

black-snow commented 1 year ago

bdc fixed the output thing as well <3 (upcoming 1.1.4, I think)

I'll close this for now.