Inclusion in F-Droid

[buongiorgio]

Hello, you already said you're not going to add the app in the F-Droid repository https://github.com/hagaygo/OpenWRTManager/issues/12 F-Droid policy permits also to someone who isn't the author to propose the inclusion of an app, if the original author does not oppose. So this issue is just to ask you if you are OK with me proposing the inclusion of your app in F-Droid.

[hagaygo]

No objection here.

[yurtpage]

@IzzySoft is any progress on this? That would be really great

[IzzySoft]

I cannot tell, I'm currently not active at F-Droid.

[IzzySoft]

@yurtpage but you can add my repo to your F-Droid Client, where OpenWrtManager is listed.

@hagaygo if you wish, you can pick a badge to link there from your Readme, so that Google one doesn't look so loneley :wink:

[yurtpage]

@IzzySoft that's sad to hear. Maybe still you may help to create the app descriptor for inclusion? That would help to get the app to the store and attract more users and contributors.

[IzzySoft]

I can send a PR with the fastlane structures if @hagaygo wants it, they are set up at my end anyway.

[hagaygo]

As far i can understand inclusion in F-Droid is awaiting donating ?

https://gitlab.com/fdroid/rfp/-/issues/2442

[yurtpage]

@IzzySoft you already sent it, ty. We need the yaml file https://gitlab.com/fdroid/fdroiddata/-/blob/master/templates/build-flutter.yml

@hagaygo that's optionally, more like to filter out garbage

[IzzySoft]

inclusion in F-Droid is awaiting donating ?

No, that is not mandatory, it's rather a hint to the possibility.

We need the yaml file

Sorry, can't help you with that. I just run a binary repo, so I don't have all the build stuff in. The parts from my YAML that would be useful there are only these:

Categories:
  - Connectivity
License: GPL-3.0-only
AuthorName: Hagay Goshen
AuthorEmail: hg40005000@gmail.com
SourceCode: https://github.com/hagaygo/OpenWrtManager
IssueTracker: https://github.com/hagaygo/OpenWrtManager/issues
Changelog: https://github.com/hagaygo/OpenWrtManager/releases

AutoName: OpenWRT Manager

// here go the build details

AutoUpdateMode: Version
UpdateCheckMode: Tags

[yurtpage]

@buongiorgio @hagaygo please answer https://gitlab.com/fdroid/rfp/-/issues/2442#note_1886854654

[hagaygo]

Normally i use the latest stable one.

3.19 currently.

[yurtpage]

@hagaygo Please join the discussion https://gitlab.com/fdroid/rfp/-/issues/2442#note_1886893631

[licaon-kter]

great, but with 3.7.12 or 3.19.6, it fails to build: https://gitlab.com/fdroid/rfp/-/issues/2442#note_1886893631

[hagaygo]

great, but with 3.7.12 or 3.19.6, it fails to build: https://gitlab.com/fdroid/rfp/-/issues/2442#note_1886893631

The log start with missing files at this point :

"Install Android SDK Platform 34 (revision: 3)" complete.
"Install Android SDK Platform 34 (revision: 3)" finished.
lib/Page/mainPage.dart:9:8: Error: Error when reading 'lib/OpenWrt/Model/AuthenticateReply.dart': No such file or directory
import 'package:openwrt_manager/OpenWrt/Model/AuthenticateReply.dart';
       ^
lib/Page/mainPage.dart:10:8: Error: Error when reading 'lib/OpenWrt/Model/CommandReplyBase.dart': No such file or directory
import 'package:openwrt_manager/OpenWrt/Model/CommandReplyBase.dart';
       ^

It seems your build does not find the app files from some reason.

[licaon-kter]

@hagaygo

It seems your build does not find the app files from some reason.

yes, Linux is case sensitive, lib/OpenWrt vs https://github.com/hagaygo/OpenWrtManager/blob/github/lib/OpenWRT :smile:

[hagaygo]

Might be the problem, i currently don't have access to a working flutter sdk environment for testing it on Linux and fixing the case sensitivity.

The folder you mentioned might be the only problem , i guess its a by product of https://github.com/hagaygo/OpenWrtManager/commit/f59b8f82c591508b419953c57ea842edc3727c0d

[yurtpage]

maybe you can make a case sensitive search in logs

[hagaygo]

maybe you can make a case sensitive search in logs

You are welcome to fork and try until it works on the fork while testing it with @licaon-kter and then create a pull request.

Currently i can test only on windows 🤷‍♂️

[hagaygo]

@licaon-kter

Hi , managed to setup a working linux development using docker

sudo docker run --name flutter --rm -v <hostAppDirectory>:/home/mobiledevops/app -it mobiledevops/flutter-sdk-image:3.19.4

Got the same errors you mentioned and fixed the filename case on https://github.com/hagaygo/OpenWrtManager/commit/d585f99f90ca9b33298d1ae6c0043dde04804234

Please try again.

Thanks.

[licaon-kter]

@hagaygo builds fine

reproducible builds ( https://f-droid.org/docs/Inclusion_How-To/#reproducible-builds ) are not possible since you build on windows and Flutter embeds its code paths ( https://f-droid.org/docs/Reproducible_Builds/#embedded-build-paths )

on macOS/Linux we can use the same path, but yours is C:/Users/hagay/source/repos/...

for autopupdates we need a place to find the exact flutter version, eg. have Flutter as a git submodule that you use during builds too so it's always up to date, or at least have it written somewhere so we can grep it

[hagaygo]

for autopupdates we need a place to find the exact flutter version, eg. have Flutter as a git submodule that you use during builds too so it's always up to date, or at least have it written somewhere so we can grep it

Hi

Placing the whole flutter SDK (even as submodule) in the repo seems wrong.

Adding a file called flutter.version in the repo root, which contains the flutter version is used ( 3.19.6 for example) would be enough ?

[licaon-kter]

Yes, just make sure to keep it up to date

[hagaygo]

@licaon-kter just added the file , please let me know if you need anything else.

[licaon-kter]

done: https://gitlab.com/fdroid/fdroiddata/-/commit/630344504218db4de351998385592e537eb661a0 :tada:

[yurtpage]

Thank you!

23 июля 2024 г. 19:00:28 GMT+03:00, Licaon_Kter @.***> пишет:

done: https://gitlab.com/fdroid/fdroiddata/-/commit/630344504218db4de351998385592e537eb661a0 :tada:

-- Reply to this email directly or view it on GitHub: https://github.com/hagaygo/OpenWrtManager/issues/37#issuecomment-2245638402 You are receiving this because you were mentioned.

Message ID: @.***> Page

[yurtpage]

Thank you @licaon-kter @hagaygo The issue can be closed

[IzzySoft]

@hagaygo as you might have missed it above: will you pick a badge to link to OpenWrtManager at IzzyOnDroid from your Readme? Looks like that badge is still missing there :wink: Thanks!

[hagaygo]

@IzzySoft Open a PR with what suppose to be missing and I'll check it out later on.

[IzzySoft]

There you go :smiley:

[licaon-kter]

Interesting placement...

[IzzySoft]

By time of publication (Play: 2020-05-03, IoD: 2022-06-16, F-Droid: 2024-07-27). Could of course also go by alphabet in reverse order if you prefer that :stuck_out_tongue_winking_eye:

[hagaygo]

Merged it after reordering it, no harm in trying 😉

[IzzySoft]

That's why I usually leave it to the authors to add the badge – so they can place it where they want to have it. You've asked for a PR – so I put it where most authors have put it lately :man_shrugging: And no offense taken :wink: Thanks!