haggis78 / BreconChurch

Files for our DH project on Henry VIII's Letter Patent founding Brecon Collegiate Church in Wales.
3 stars 0 forks source link

New Bug Issue #38

Open alnopa9 opened 4 years ago

alnopa9 commented 4 years ago

This will be the new bug dump issue. Feel free to add to it if you see anything.

Additions:

amberpeddicord commented 4 years ago

@alnopa9 I made changes to the code for the timeline, but when I tried to put it on the site, I didn't have file permissions any longer.

ebeshero commented 4 years ago

@amberpeddicord @alnopa9 I logged in to our server and saw the permission settings for group access had changed from brecon to users. I just reset Amber as owner and brecon as group for all your files. Try now!

ebeshero commented 4 years ago

Well, by "now"...I might have to take newtfire offline for a few minutes this morning. It needs some package updates for security! So if it's unavailable for a moment, come back and try again a little later.

amberpeddicord commented 4 years ago

@ebeshero @alnopa9 It worked! I still have some work to do on it but I was able to put it on the site at least.

ebeshero commented 4 years ago

@amberpeddicord Thanks for putting it up on the site--it's easier to see what you're doing there and how it's coming out for web view. :-) This is definitely a scaling challenge. How small can it get? With the mouseover text appearing, it's okay for the text boxes to overlap each other (as long as all the others are reliably shut off when one is displaying). But you may want a strategy for when all the circles are clustered together, to make it so one text box appears above the line and others below or something? Not sure--and I'm curious to see how it keeps developing.

ebeshero commented 4 years ago

@alnopa9 I won’t know until I can see the code, but it sounds like the show/hide code is tied to the entire form or the attributes involved aren’t properly matching up. If the JS file hasn’t changed, think about what has changed in the new HTML!

Sent from my iPhone

On Jan 16, 2020, at 5:06 PM, Alyssa Argento notifications@github.com wrote:

@ebeshero I have a new reader somewhat put together but there's a major problem with it. Whenever you deselect a checkbox, the checkbox disappears. Even worse, if you select and then deselect the first one, for C, then all of the check boxes disappear. The only way to make them reappear is to reload the whole page. Do you know why this is happening?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

alnopa9 commented 4 years ago

@ebeshero I found the bug and fixed it. I just need to fix some spacing issues with the layout now.

Update: I fixed the spacing issues. commit

ebeshero commented 4 years ago

Oops! I was just cheering you on, @alnopa9 ! I didn't mean to close this issue! :-) Congrats on the debugging!

alnopa9 commented 4 years ago

@ebeshero @amberpeddicord @haggis78 I have a somewhat working reader now. commit

amberpeddicord commented 4 years ago

@alnopa9 @ebeshero @haggis78 I fixed the text alignment and added a link to our source code to the index page.

amberpeddicord commented 4 years ago

@alnopa9 I have an HTML/CSS question: I'm trying to put an overlay on an image I added to the index page and put a link on it (which I was able to do!). But, I originally had the image centered, and when I added the overlay it changed the positioning, and I don't know how to fix it.

alnopa9 commented 4 years ago

@amberpeddicord I'll look into it now.

Edit: I'm not on my personal laptop, so I just now got everything set up to look at and edit. I did notice that the overlay class is set as display: block, which I think is the problem.

Edit: I think I fixed it! I'm not on my laptop, so I don't have access to the server. Feel free to update the server when you get a chance.

amberpeddicord commented 4 years ago

@alnopa9 Updated! Thank you!

alnopa9 commented 4 years ago

Just updated the Graphs page to include the remaining AB's and be accurate with the ones that are already marked. commit

alnopa9 commented 4 years ago

Updated the current Comparison page to include superscripts. commit

alnopa9 commented 4 years ago

Just pushed a big update to the repo commit

alnopa9 commented 4 years ago

@amberpeddicord I updated the timeline to be entirely vertical with working javascript. I'll be home in about 2 hours, but if you see this before then, you can update the server. commit

alnopa9 commented 4 years ago

@ebeshero @amberpeddicord I no longer have permissions to update the server. Amber, if you do a complete server update, I will be able to see what I need to still change. In the meantime, I'll be working on a third viewer.

amberpeddicord commented 4 years ago

@alnopa9 Updated!

alnopa9 commented 4 years ago

@amberpeddicord I fixed some nav bar issues. Can you push again and also update the javascript folder on the server?

Edit: Also, update the timeline html page again. I updated the javascript meta line in the head.

alnopa9 commented 4 years ago

Fixed some small bugs Updated nav bars Corrected javascript meta line in head for timeline page Fixed remaining validation issues

amberpeddicord commented 4 years ago

@alnopa9 Updated, and the timeline seems to be working!

alnopa9 commented 4 years ago

@amberpeddicord I had to update the SSI for the separate display pages. commit

alnopa9 commented 4 years ago

Updating with a few commits: Updating timeline Updated timeline javascript with loops Updated SSIs to link to stemma on TA page, fixed text and centered graphs on TA page

alnopa9 commented 4 years ago

Fixed loops in timeline javascript commit one commit two

@amberpeddicord ready for a server update! 😄

alnopa9 commented 4 years ago

@haggis78 For the stemma, instead of having its own page, now the nav bar links to the part of the textual analysis page that shows the stemma.

amberpeddicord commented 4 years ago

@alnopa9 Updated!

alnopa9 commented 4 years ago

@ebeshero @haggis78 @amberpeddicord and I updated the timeline to be a little more interactive and removed the horizontal scrolling.

haggis78 commented 4 years ago

@amberpeddicord @alnopa9 I like the new format for the timeline. Being able to click on a given century for an expanded version below is a neat solution to the linear compression problem. Well done.

alnopa9 commented 4 years ago

Updated the color scheme for the timeline

alnopa9 commented 4 years ago

@amberpeddicord I just got the loops to work for highlighting the shapes for the second timeline! 😸 Ready to update the server! 🚀

Working timeline

amberpeddicord commented 4 years ago

@alnopa9 Updated!

amberpeddicord commented 4 years ago

@alnopa9 There was another double header on the timeline page so I fixed that and pushed the changes to the repo and the server!

Edit: I also made like...several Big Errors™ while doing so, but I fixed those!

alnopa9 commented 4 years ago

@amberpeddicord You can update the server for the timeline.

amberpeddicord commented 4 years ago

@alnopa9 Updated!

alnopa9 commented 4 years ago

@amberpeddicord @haggis78 I just pushed tsv tables to use to make the network graphs. There is one for each anonymous Block as well as one to compare each edition as a whole.

commit

alnopa9 commented 4 years ago

@amberpeddicord can you update the server?

alnopa9 commented 4 years ago

I just finished up the first rough draft for the network analysis page.

commit

amberpeddicord commented 4 years ago

@alnopa9 Updated!

alnopa9 commented 4 years ago

@amberpeddicord I'm not on my computer, does everything look okay?

amberpeddicord commented 4 years ago

@alnopa9 The graphs are showing up, but it looks like there's an issue with the navbar not showing up on that page.

alnopa9 commented 4 years ago

@amberpeddicord there's an error in the file paths on the SSI page then. I'll be home in about an hour to fix it, unless you want to try.

amberpeddicord commented 4 years ago

@alnopa9 I'll be done in class at 11:50 so ill look at it then!

amberpeddicord commented 4 years ago

@alnopa9 All fixed!

alnopa9 commented 4 years ago

Made an interactive table to go on the network analysis page.

commit

amberpeddicord commented 4 years ago

@alnopa9 I updated the server!

alnopa9 commented 4 years ago

Updated the network analysis page to highlight individual tds in the right hand table and added a table on the left. commit

@amberpeddicord can you update the server?

alnopa9 commented 4 years ago

Updated the network analysis page to highlight individual lines. commit

amberpeddicord commented 4 years ago

@alnopa9 Updated!

alnopa9 commented 4 years ago

Updated the network analysis page to highlight matching lines on the star graph with their td commit

@amberpeddicord can you update the server?