haghish / github

a module for building, searching, installing, managing, and mining Stata packages from GitHub
http://haghish.github.io/github/
101 stars 41 forks source link

`github` doesn't add itself to the package list #21

Open bquistorff opened 3 years ago

bquistorff commented 3 years ago

I did a fresh install of github and used it to install rcall. During the installation process its dependency.do queried for the github version, which isn't in the dataset, giving the following error:

. quietly github version github
github package was not found

I'm not sure if this is a rcall or github issue.

randrescastaneda commented 2 years ago

Did you use github to install github? Say, github install haghish/github. If you do, it works fine.

image

@bquistorff

bquistorff commented 2 years ago

No, I did a net install following the instructions).

randrescastaneda commented 2 years ago

Right. The problem is that github version reads from file g/github.dta , which is updated with the subcommand githubdb add. This subcommand is executed inside github install right after the Stata package is installed using net install. One solution is suggest the following in the instructions

net install github, from("https://haghish.github.io/github/")
github install haghish/github

or

net install github, from("https://haghish.github.io/github/")
githubdb add, address("haghish/github") username("haghish")  ///
                      reponame("github") name("github")

I know. It is overkill, but I don't see another way to solve it.

bquistorff commented 2 years ago

If they are feasible, a few other options that don't require user changes could be:

mronkko commented 2 weeks ago

This is clearly a bug. If a user does not have github installed, they must use the "net install" method. But if this method is used, installing rcall fails unless the user realizes that they must install github twice for it to actually work.