hahnec / plenopticam

Light-field imaging application for plenoptic cameras
http://www.plenoptic.info
GNU General Public License v3.0
200 stars 37 forks source link

Bugfix/demo fixes #17

Closed toth2peter closed 3 years ago

toth2peter commented 3 years ago

Hi @hahnec

Two minor fixes in examples/04_illum_demo.ipynb:

Changes can be tested at https://colab.research.google.com/github/toth2peter/plenopticam/blob/bugfix/demo-fixes/examples/04_illum_demo.ipynb

Should you request any changes at this Pull Request please contact me, thanks in advance.

hahnec commented 3 years ago

Hey @toth2peter.

Thanks for the PR and pointing this out. I will merge your findings for the upcoming release as I am occasionally working on a v0.7.0 of plenopticam.

'imagemagick' was actually only supposed to run on my local machine as it proved to render gif-animations with a more pleasing quality than 'pillow'. I might add a try-except block later for a safer export. Thanks for fixing the versioning in the Colab notebook.