search

hai-vr / lightbox-viewer

Lightbox Viewer lets you simultaneously visualize changes in shader material settings under different lighting conditions.
https://docs.hai-vr.dev/docs/products/lightbox-viewer
MIT License
96 stars 3 forks source link

[Feature Request] Package lightbox-viewer for UPM / VPM #4

Open TayouVR opened 2 years ago

TayouVR commented 2 years ago

I have already started doing so myself at https://github.com/TayouVR/lightbox-viewer/tree/UPM, however there are some issues I have not had the time to figure out and resolve (need to copy the package with scenes into the project via https://docs.unity3d.com/ScriptReference/PackageManager.Client.Embed.html) -> https://forum.unity.com/threads/read-only-scenes-in-packages.891184/ -> https://forum.unity.com/threads/it-is-not-allowed-to-open-a-scene-in-a-read-only-package-why.1148036/

I hope you will consider it and can make use of my fork. I have a bit of changes in The main window code locally too, where I tried to add Client.Embed(), but I couldn't figure out how exactly to implement it, so I'll have to leave that up to you or someone else to figure out.

hai-vr commented 2 years ago

Hello,

As I said on my Discord server, discussions I've had regarding VPM in content creation circles have let me decide that I will not package any of my projects to UPM / VPM for the time being while I am currently monitoring the VPM situation for possible changes.

Sorry, this is not a technical problem, it's a political one.

TayouVR commented 2 years ago

oh, I work on that branch actually before VPM, as I just prefer UPM over loose .unitypackages... I wasn't aware of such issues, but I appreciate the answer. I am not in your discord server, so I haven't seen that post, sorry.

ZenithVal commented 1 year ago

Year later, any changes on this with the new VPM template & updated VCC?

hai-vr commented 1 year ago

Year later, any changes on this with the new VPM template & updated VCC?

As I discussed numerous times on Discord, VCC support will not be added on any of my projects. Some members of the VRChat team are made well aware of the problems I have with VCC as a tool creator (I'm not speaking as an user of VCC, but as a tool creator, which has different implications), it's up to them to decide if they want to make changes that could potentially alleviate my concerns and change my opinion on VCC.

As far as I know, there might be steps towards that direction, so who knows.