haihw / pic_moments

0 stars 0 forks source link

[Editing] There are no direction written how to work with curve #27

Closed share2people closed 11 years ago

share2people commented 11 years ago

Description: [Editing] There are no direction written how to work with curve Like hue, opacity, brightness etc should be written in the direction in such a way that user can understand what he is using.

Steps:

  1. Open the application and choose editing part.
  2. Now, click on the curve.
  3. There is no direction or text how to use curve.

Result: There is no direction how to choose the curve.

Expected: there should be some good direction how to choose the curve.

share2people commented 11 years ago

Adding to that, if saturation , hue or other effect will take place there number from 0 to 200 should be displayed to the user.

haihw commented 11 years ago

We've already displayed that number on GUI About the Curves, you can provide instruction, if possible, we will add to GUI. Other photo apps has no instruction in Curves Toning feature.

share2people commented 11 years ago

I tried on iPhone4(6.1.3) and iPod(6.1.4) but I am not able to see the number on GUI. Possibly is this a bug. Moreover, if you will provide the directions like click on the line so that a square is appeared. Also, could you please tell things you have implemented in the curve e.g. saturation at which square box so that we can prepare the instructions and tell you guys.

haihw commented 11 years ago

You are confusing between Curves tone and Saturation. There is no square box is saturation or anything else, they all are Curves point.

share2people commented 11 years ago

Can you please give a little light, how you implemented that feature. I am able to see the curve point when I tab on the curve on different x, y position. There are total 5 curve points in total if I am not wrong.

haihw commented 11 years ago

Curves toning is similar to Curves function in other photo editing program on PC, I mean similar, not exactly same because nobody know how Adobe implement their Photoshop. Or do you need saturation, hue, brightness, contrast like blend InstaCamera instead of Curves?

share2people commented 11 years ago

I think, I am not able to understand you. Let me try again, see I clicked on the middle of the curve , I get a curve point. Am I right? Now, if I started to slide the curve point in the west-south direction then changes will start reflected. So, if I am not wrong that must be brightness on that curve point. So, In total I am able to see 5 curve point on different x,y positions of the curve. See the attached png. Now, each curve point( black squares on the curve) have some meaning. Right? Please tell if still I am not able to understand you the things. img_0223

haihw commented 11 years ago

No, you are misunderstand about Tone Curves function in image processing All points together make the Curve. And that curve transform value space of each pixel in the image that transforms the tone of image. Individual point does not make any thing.

share2people commented 11 years ago

Yes, you are right, all points todether make the curve. Can we show the transform value which the transforms the tone of image between reset and close icon. Also, can we highlight when click on the curve icon , that tab on the curve and slide to use the curve. Something like this.

haihw commented 11 years ago

That is the matrix with 256x256x256 values, do you want to show them?

share2people commented 11 years ago

Yes, could you please show that in a meaningful way. As this is a very cool feature and user will not come to know what they are doing exactly. So, if you guys able to add some instruction what they are doing exactly with that then what would make this one complete.

Also, for my knowledge what exactly this matrix is doing in terms of 5 curve points in the curve

haihw commented 11 years ago

If user similar with lighting room, photoshop or Gimp, they will know about Tone Curves It's difficult to display instruction in curves view. If you need you should do it in a getting started view.

haihw commented 11 years ago

http://en.wikipedia.org/wiki/Curve_(tonality)

haihw commented 11 years ago

I think user will be interested when they can figure out this feature. The usage with curve is easy and they can see the result real-time when playing with control point. So we don't need to add any instruction that can make them confused.

share2people commented 11 years ago

I think you are write, should we show the direction like Tab on the line to get control points, something like that, through this at least they same to know how control points come. We are studying about tone curve and probably give some easy instructions if possible.

haihw commented 11 years ago

So I will add text instruction "Tap to add control point and drag to control the curve" when curves view appear like I did in Collage mode or edit mode "Tap to add..."

share2people commented 11 years ago

Can you use LATO font in this. Even if possible can you use LATO font other parts.