search

haiilo / catalyst

A framework agnostic design system and component library based on web components and SCSS.
https://haiilo.github.io/catalyst/
MIT License
7 stars 6 forks source link

Cat-dialog: expose cat-scrollable properties? #510

Closed glushkova91 closed 2 months ago

glushkova91 commented 2 months ago

I'm not sure if this suggestion can be considered as an improvement so I'm creating a question first: do we want to expose cat-scrollable properties outside cat-dialog component to allow the user to configure it? Or at least some of them. Recently we implemented the dialog which should load more content when user scrolls and hits the bottom. We went with workaround putting cat-scrollable inside cat-dialog content with needed configuration though it feels like it would be better to use cat-scrollable from dialog and be able to pass needed properties and listen outputs. For now I'd add the next properties noOverscroll, noScrolledInit, scrolledBuffer and scrolledBottom method. @fynnfeldpausch let me know what do you think, if you are ok I'll open PR with changes.

fynnfeldpausch commented 2 months ago

Hey. good question. What do you think? In general, I think it'd be good to not link the different components. Technically we should probably not include the cat-scrollable in the dialog be default and let everyone just place it themseves. But then it is forgotten all the time. So in this case, I think we should go for it. 👍

glushkova91 commented 2 months ago

@fynnfeldpausch https://github.com/haiilo/catalyst/pull/512