search

haijeploeg / excludarr

Excludarr manages your libraries in Radarr/Sonarr. It keeps track of your library and checks if your movies and series are also available on a configured streaming provider. It can exclude the movies and series that are available on a configured streaming provider. But it can also re-add movies and series if they are not streaming anymore.
MIT License
194 stars 13 forks source link

JustWatch Not Found error since 2023/10/12 #92

Open dduives opened 9 months ago

dduives commented 9 months ago

Describe the bug Has always been working fine but has been throwing the error excludarr.modules.justwatch.exceptions.JustWatchNotFound since 2023/10/12

Before that it sometimes worked but occasionally has thrown this error: Max retries exceeded with url: /content/locales/state

After that it has been throwing the JustWatchNotFound error for the last 8 days

Versions

  1. OS Version: Docker on Synology
  2. Excludarr version: 1.0.7
  3. Python version: 3.10

Log: excludarr.csv

LucaVignati commented 9 months ago

I have the same error, I am on Unraid 6.12.4

reaper commented 8 months ago

+1

Pauwelz commented 8 months ago

Probably because the JustWatch API address defined justwatch.py @ line 13 no longer exists.

Seems like it was replaced with a GraphQL endpoint located at https://apis.justwatch.com/graphql.

Sadly I'm not fluent enough in Python to fix this. Maybe someone else can pick this up.

haijeploeg commented 8 months ago

Yep, they have changed the API to a graphql endpoint. Im not sure how to quickfix this as the whole API client needs to be rewritten. Sadly I don't have any spare time anymore to maintain this tool... Maybe in the future I will look into this.

keldian commented 5 months ago

Could you not leverage https://github.com/Electronic-Mango/simple-justwatch-python-api for this?

TheArturthur commented 4 months ago

Could you not leverage https://github.com/Electronic-Mango/simple-justwatch-python-api for this?

Apparently no. In terms of licensing, as that repo is under GPLv3, this one must be under the same license (currently is using MIT).

I've forked this project to try and come up with a solution using GraphQL requests. I don't have much time, but will try my best.

jelias commented 3 months ago

@TheArturthur curious what the status of your GQL implementation is? Was looking through your code and it seemed decently far along...

Were you able to get a working implementation?

TheArturthur commented 3 months ago

No, I've been quite busy to sit down with it. I've managed to try requests that should be made to the API, though. Hopefully, my schedule will allow me to spend some time with it...

g-nogueira commented 3 months ago

I really want to use this project also. After I'm done with some changes I would personally like on botdarr, I will give a try on this one.

scott-es commented 3 months ago

I was looking into this project rather than try to create something from scratch, but it appears it's unmaintained. @haijeploeg are you looking to transfer ownership of this project to continue to evolve it? Is there a better place (e.g. some discord server) to discuss the future of a solution for the use cases solved by Excludarr?

I may be able to make the updates to work with GQL for justwatch, but no PRs on this repo have been merged since '22, worst case we end up with a fork with a bunch of needed updates ...

TheArturthur commented 2 months ago

Is it possible/legal for us to use any of the created forks for this, even without his response? Or even a new one inside an org? Obviously, giving him credit for the original idea and development, but being able to improve it.

scott-es commented 2 months ago

Is it possible/legal for us to use any of the created forks for this, even without his response? Or even a new one inside an org? Obviously, giving him credit for the original idea and development, but being able to improve it.

Yes, it's MIT license

TheArturthur commented 2 months ago

Great, I just created a free org, imported my fork, and made you all owners. Feel free to edit the org config as you think best!

https://github.com/excludarr

scott-es commented 2 months ago

Great, I just created a free org, imported my fork, and made you all owners. Feel free to edit the org config as you think best!

https://github.com/excludarr

Great! thank you for doing that! accepted the invite. I will work on submitting an update to fix this issue, as soon as I have something of decent progress I'll commit and raise a WIP PR. Will continue discussion then on other new repository. Too bad there is not a way (AFAIK) to "take over" abandoned projects but at least the new org will have multiple owners and maintainers hopefully.

scott-es commented 2 months ago

let's continue the discussion about fixing this in the corresponding issue in the new fork