search

haikuports / haikuporter

The tool that builds HaikuPorts recipes.
MIT License
41 stars 44 forks source link

addResourcesToBinaries should call mimeset #133

Open diversys opened 7 years ago

diversys commented 7 years ago

Attributes never make it to the binaries unless mimeset is explicitly called in the recipe. Normally Tracker would set them upon identification, however this only works on non read only FS. https://github.com/haikuports/haikuporter/blob/master/HaikuPorter/ShellScriptlets.py#L472

diversys commented 7 years ago

Also these could be probably removed after fixing the issue:

inrecipe mimeset
/data/ports/app-admin/keepassx/keepassx-2.0a5.recipe:71:    mimeset -f $sourceDir/src/keepassx
/data/ports/app-admin/keepassx/keepassx-2.0a6.recipe:75:    mimeset -f $sourceDir/src/keepassx
/data/ports/app-admin/keepassxc/keepassxc-2.1.0.recipe:85:      mimeset -f $sourceDir/src/keepassxc
/data/ports/app-emulation/aranym/aranym-0.9.15_git.recipe:50:   mimeset $prefix/bin/aranym
/data/ports/app-emulation/oricutron/oricutron-1.1_svn.recipe:43:        mimeset $prefix/apps/Oricutron/oricutron
/data/ports/dev-qt/qt5/qt5-5.9.1.recipe:473:            mimeset -f "$binDir/$j"
/data/ports/games-puzzle/lmarbles/lmarbles-1.0.8.recipe:63:     mimeset -f $appsDir/LMarbles
/data/ports/haiku-apps/bdhcalc/bdhcalc-1.1.recipe:36:   mimeset -f bdhcalc
/data/ports/haiku-apps/converttolf/converttolf-0.0.0.recipe:43: mimeset -f ConvertToLF
/data/ports/haiku-apps/filecropper/filecropper-1.recipe:36:     mimeset -f FileCropper
/data/ports/haiku-apps/fortuna/fortuna-1.0.0.recipe:41: mimeset -f Fortuna
/data/ports/haiku-apps/minimizeall/minimizeall-1.0.0.recipe:50: mimeset -f ../bin/MinimizeAll
/data/ports/haiku-apps/minimizeall/minimizeall-1.0.0.recipe:58: mimeset -f ../bin/DeskbarAddOn
/data/ports/haiku-apps/phantomlimb/phantomlimb-1.recipe:49:     mimeset -f PhantomLimb
/data/ports/haiku-apps/runprogram/runprogram-1.0rc1.recipe:42:  mimeset -f RunProgram
/data/ports/haiku-apps/systeminfo/systeminfo-2.recipe:46:       mimeset -f SystemInfo
/data/ports/kde-misc/kdiff3/kdiff3-0.9.97.recipe:57:    mimeset -f kdiff3
/data/ports/net-im/vacuum/vacuum-1.2.5.recipe:65:       # For some reason attributes are missing without mimeset
/data/ports/net-im/vacuum/vacuum-1.2.5.recipe:66:       mimeset -f $appsDir/Vacuum-IM/Vacuum
/data/ports/net-irc/quassel/quassel-0.10.0.recipe:71:   mimeset -f quassel
/data/ports/net-irc/quassel/quassel-0.10.0.recipe:72:   mimeset -f quasselclient
/data/ports/net-irc/quassel/quassel-0.10.0.recipe:73:   mimeset -f quasselcore
/data/ports/net-irc/quassel/quassel-0.13_git.recipe:81: mimeset -f quassel
/data/ports/net-irc/quassel/quassel-0.13_git.recipe:82: mimeset -f quasselclient
/data/ports/net-irc/quassel/quassel-0.13_git.recipe:83: mimeset -f quasselcore
/data/ports/www-client/links/links-2.3pre2.recipe:58:   mimeset links
mmuman commented 7 years ago

Doesn't (or shouldn't?) haikuporter actually run mimeset over all the files before packaging??

korli commented 7 years ago

It does: https://github.com/haikuports/haikuporter/blob/master/HaikuPorter/Package.py#L245

mmuman commented 7 years ago

Then something is broken. Maybe it doesn't act because the binary was already sniffed before adding the resources?

pulkomandy commented 7 years ago

Adding -f to the command line would fix that?

phoudoin commented 6 years ago

-f or -F (which will also update the file type) ?