haikuports / haikuports

Software ports for the Haiku operating system.
MIT License
419 stars 308 forks source link

gitk (from git_gui package) immediately crashes when starting #7392

Open pulkomandy opened 2 years ago

pulkomandy commented 2 years ago

I get this message in terminal after the window shortly blinking on screen:

/Git/haiku/renga> gitk --all
CRITICAL: Error in startup script: bad screen distance "5.0"
    while executing
"$canv conf -scrollregion [list 0 0 $canvxmax $ymax]"
    (procedure "setcanvscroll" line 6)
    invoked from within
"setcanvscroll"
    (procedure "initlayout" line 17)
    invoked from within
"initlayout"
    (procedure "getcommits" line 4)
    invoked from within
"getcommits {}"
    (file "/bin/gitk" line 12704)
Begasus commented 2 years ago

Never used gitk myself, but on testing a previous bump I stumbled into this also. Getting a different error here while executing the cmd:

/Opslag/sandbox> gitk
CRITICAL: Error in startup script: bad geometry specifier "800x-12"
    while executing
"wm geometry . "${w}x$h""
    (procedure "makewindow" line 413)
    invoked from within
"makewindow"
    (file "/bin/gitk" line 12639)
lonemadmax commented 2 years ago

Works for me, but I have just installed it.

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=895446 is similar enough and points to something with the locale, though I have not been able to reproduce it after changing to different languages and decimal separators.

For @Begasus's one, I'd have a look in the config file ~/config/settings/git/gitk, in particular a line with set geometry(main).

Begasus commented 2 years ago

I'd have a look in the config file ~/config/settings/git/gitk, in particular a line with set geometry(main).

In there it says: set geometry(main) 2048x-12+60+93

EDIT after deleting the line mentioned (found through stackoverflow) I'm at the point with the same error as @pulkomandy

pulkomandy commented 1 year ago

This depends on the locale.

"5.0" is not convertible to int in French (it should be 5,0).

By using 'LANG=C LC_ALL=C gitk' I can start it and it doesn't crash.

Begasus commented 4 months ago

Is this still valid? Latest checks showed no crashes here.