search

hail2u / html-best-practices

For writing maintainable and scalable HTML documents
4.11k stars 439 forks source link

Fix usage of absolute where relative should be #108

Closed vikaskharkwal closed 2 years ago

vikaskharkwal commented 2 years ago

Problem

The example in "Use absolute path for internal links" section represents absolute path to be a bad practice but the heading and the text of the section say otherwise. Also, for internal links relative path is better as the protocol and domain name can be omitted as they already match the site's and the file can be located based on where it's found relative to the current document.

Fix

I've made changes by replacing absolute with relative in the section.

More clarification

In case you meant absolute path as what is called absolute path in terms of Linux (starting with / which is root) I think it should use relative instead of absolute in that sense that it is a relative path on the web based on document root of the website. Using absolute in this sense would only confuse learners new to HTML who still don't know much about Linux filesystem.

hail2u commented 2 years ago

Technically, these are “path-absolute-URL string”. I think they should not be called “relative”.

vikaskharkwal commented 2 years ago

Reading the spec, I understand what you're trying to say. In that case, I believe the wording can be modified or maybe even the example as the bad practice code snippet shows the usage of absolute-URL string in addition to the scheme-relative-URL string which creates confusion as to what the section wants to convey.

hail2u commented 2 years ago

I don’t think so.