search

hail2u / node-css-mqpacker

Pack same CSS media query rules into one using PostCSS
675 stars 60 forks source link

What are the breaking change(s) from v6 to v7? #68

Closed kyleoliveiro closed 5 years ago

hail2u commented 5 years ago

https://github.com/hail2u/node-css-mqpacker/releases/tag/v7.0.0

kyleoliveiro commented 5 years ago

No changelog? ☹️

hail2u commented 5 years ago

There are release notes.

kyleoliveiro commented 5 years ago

Sorry, maybe I'm missing something. But all I see is:

This release supports PostCSS v7.

hail2u commented 5 years ago

Updating PostCSS major version is a breaking change, because it may (or may not) break your PostCSS stacks.

kyleoliveiro commented 5 years ago

Does mqpacker v7 still support PostCSS v6? If so, then IMO it is not a breaking change since the user can opt not to upgrade to PostCSS v7.

hail2u commented 5 years ago

PostCSS v7 drops Node.js v4 support. This means, if a user uses Node.js v4, the css-mqpacker CLI won’t run. This will easily happen if I update PostCSS major version in css-mqpacker minor (or patch) version.

kyleoliveiro commented 5 years ago

Ah, I see. Didn't realise that postcss was listed as a dependency. All good then. Thanks :smile: