search

haileys / twostroke

A Javascript implementation in Ruby!
MIT License
303 stars 19 forks source link

Assertion in test using Japanese Windows XP / Ruby Installer #5

Closed fritzsche closed 12 years ago

fritzsche commented 12 years ago

Hi Charlie,

after fix reported in issue #4 I can run the test suite but still have 2 assertions as shown below. I understand that windows might not be in focus on this early stage of development but any ideas?

Thanks, Thomas

................................... test/exceptions.js FAIL finally still executes if catch throws an exception and the exception keeps bubbling up Assertion failed after 0 assertions: .................................................... test/semicolon_insertion.js FAIL return is greedily semicolon inserted Assertion failed after 0 assertions: !== <1>
.............................................................................................Coverage report generated for test.rb to D:/Rails/twostroke/coverage. 2621 / 2742 LOC (95.59%) covered.

haileys commented 12 years ago

I shouldn't say that those failures are supposed to be happening, but I do know about them and it isn't any of your fault.

One's for an edge case with exceptions that I have to fix, the other is a reminder for me to implement semicolon insertion.

I'll leave this ticket open until I fix that

haileys commented 12 years ago

All tests are passing now!