hailwood / jQuery-Tagit

The Jquery Tagit Plugin transforms an html unordered list into a unique tagging plugin.
264 stars 109 forks source link

Deleting problem with tags that contains : ' #30

Closed Foine closed 12 years ago

Foine commented 12 years ago

I had an issue in deleting tags which contains the character '. The value wasn't removed in the select. So I changed the _popSelect method :

 _popSelect: function(text) {
    // before
   // this.select.children('option[value="' + text + '"]').remove();

    this.select.children().each(function(index) {
        if($(this).val() == text) {
            $(this).remove();
        }
    });
}

That works :)

hailwood commented 12 years ago

Brilliant. Can you please create a pull request with the changes?

Foine commented 12 years ago

Thanks. I will do that has soon as possible.