search

hailwood / jQuery-Tagit

The Jquery Tagit Plugin transforms an html unordered list into a unique tagging plugin.
264 stars 109 forks source link

Some added options, html escaping, a bug fix, and some refactoring #49

Closed eranation closed 12 years ago

eranation commented 12 years ago

see line comments on the commit for more details

hailwood commented 12 years ago

Hi @eranation These all look great, May I please ask you to also merge these changes into the tagit.themeroller.js file as well? (If not let me know and I can do so, It just shows up better if you put the changes in there yourself!)

eranation commented 12 years ago

will do my best... :)

great plugin by the way, best I've found so far for tagging thanks!

hailwood commented 12 years ago

Hey @eranation cheers for the comment, It's actually come a long way since I first started it mostly due to the ossc such as yourself!

Anyway, just checking how you are getting on merging the changes into the tagit.themeroller.js as well?

eranation commented 12 years ago

didn't get to it yet, but I added some more changes, will let you know once it's ready for a pull for now you can close it and ignore the changes thanks!

mikesnare commented 12 years ago

Any idea when this might get merged? I'm using this plugin (it's awesome, by the way) and I've had to monkey patch to support both HTML escaping and autogrow on the input. Came here to try to issue a pull request only to find my fixes have already been done! I'd like to use the master branch here rather than mine or eranation's if possible. Thanks!

hailwood commented 12 years ago

These changes will be pulled when the alterations are also made in tagit.themeroller.js as both versions need to be kept in-sync, unfortunately I don't have time to actively work on this plugin, if you would like to copy the changes into tagit.themeroller.js as it looks like @eranation has the time either! then I will merge both pull requests!