hailwood / jQuery-Tagit

The Jquery Tagit Plugin transforms an html unordered list into a unique tagging plugin.
264 stars 109 forks source link

Tag edit support #65

Closed AAverin closed 11 years ago

AAverin commented 11 years ago

Implemented tags edit feature, added a couple of fixes. Details:

small fixes:

  1. 'style' is now cleared after highlight animation, so it no longer messes with other things you want to style.
  2. fixed #61

features:

  1. each tag label is now marked as 'tagit-label' class - simplifies use of ellipsis for tags and etc.
  2. option 'editable', methods _edit and _postEdit were added

Edit logic: if 'editable=true' click on a tag:

Anyway, all this is in code, some comments were also added. With lots of css changes for tagit in my project I wasn't able to add sample styles for: 'tagit-edit', 'hidden', 'edited', 'tagit-label' I hope you will figure our yourself how to style these parts.

Changes were also added to tagit-themeroller, although weren't tested, so be careful when using.

hailwood commented 11 years ago

@AAverin Two things, One: You might want to check your git settings, all your commits are coming through as invalid-email-address. Two: The rest of your commits have been good, and this looks good too and a large contribution, I have added you as a collaborator on the repository so you should be able to just push straight to the repository now.

Can you please organise manually merging these?

AAverin commented 11 years ago

@hailwood Thanks for allowing me to push directly=) Not sure I will have time to actively contribute to tagit, but if during my use of the plugin I fix other bugs or implement new features I will push them for sure. I'm still quite new to Git, but I will try to find a way to merge edit feature to the master branch. Issue with invalid-email-address appears because I use not git as the client, but mercurial with a hggit plugin installed, and mercurial has some different user name format - I didn't yet figured out how to write it so that Git would parse it properly.