search

haim-io / cypress-image-diff

Visual regression test with cypress
MIT License
251 stars 62 forks source link

fix: creating report if taking pictures with nested folders #162

Closed haicaodac closed 1 year ago

haicaodac commented 1 year ago

Error creating report if taking pictures with nested folders. Example: cypress-visual-screenshots/comparison/folder-1/folder-2/image.png image

PippoRaimondi commented 1 year ago

Nice, thanks for catching this one!! could you update the commit to take a valid prefix from the CONTRIBUTION.md?

I.E feat: creating report if taking pictures with nested folders

haicaodac commented 1 year ago

Nice, thanks for catching this one!! could you update the commit to take a valid prefix from the CONTRIBUTION.md?

I.E feat: creating report if taking pictures with nested folders

Yeb, I have updated my pull title and commit title. It worked before and only had a small bug so I'll create a "fix" tag

PippoRaimondi commented 1 year ago

Thanks for the contribution! LGTM!

PippoRaimondiDIT commented 1 year ago

:tada: This PR is included in version 1.27.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: