search

haim-io / cypress-image-diff

Visual regression test with cypress
MIT License
240 stars 62 forks source link

Incorrect Difference Percentage Resulting from compareSnapshot Command #184

Closed palmera01 closed 5 months ago

palmera01 commented 9 months ago

I was looking into the difference percentages and I noticed that they are different from what I expected them to be. Here are a few screenshots from a report where I created baseline images with a specified percent of pixels different between the two images and compared them. The title of each screenshot has the percentage of pixels different between the created baseline image and the image taken in the compareSnapshot command: image image image image

I believe this difference is coming from the fact that the difference percentage is square rooted when I don't believe it should be. Is this the expected behavior and I am misunderstanding the percentage value or is this a bug in the package? I saw this behavior on both 1.26.0 and 1.30.1. Thanks!

github-actions[bot] commented 8 months ago

This issue is stale because it has been open for 30 days with no activity.

tamasmagyar commented 8 months ago

Hi @palmera01

Thanks for raising the question. Based on the provided info it looks like it is incorrect at the moment.

We are currently working on a newer version of the report. Hopeful that's going to fix the issue. Let's keep the issue open until we are sure.

github-actions[bot] commented 7 months ago

This issue is stale because it has been open for 30 days with no activity.

tamasmagyar commented 7 months ago

Keeping the issue open until tested with v2.0.0

github-actions[bot] commented 6 months ago

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] commented 5 months ago

This issue was closed because it has been inactive for 30 days since being marked as stale.