haimgel / display-switch

Turn a $30 USB switch into a full-featured multi-monitor KVM switch
https://haim.dev/posts/2020-07-28-dual-monitor-kvm/
MIT License
2.86k stars 112 forks source link

Better display ID on Linux (#54) #58

Closed haimgel closed 3 years ago

haimgel commented 3 years ago

Make a display name on Linux behave more closely to how it works on MacOS and Windows, a slight refactor of #56

pm215 commented 3 years ago

Thanks for refactoring my attempt at this. I've tested it and display names now look like this:

19:44:43 [INFO] Display 'DEL DELL U2719D 361PY13' is currently set to Custom(0x1111)

which I think is the intention.

NB: this will break anybody currently using monitor_id on Linux hosts; given that the Linux major:minor device number is pretty unhelpful information I think the new display name string format is better, but if you have anything like release notes or equivalent it might be worth noting that this is an intentional backcompat break.

haimgel commented 3 years ago

That's a great callout, thank you for that!