search

haimkastner / unitsnet-js

A better way to hold unit variables and easily convert to the destination unit
https://www.npmjs.com/package/unitsnet-js
MIT License
23 stars 8 forks source link

API DTO Implementation #32

Closed haimkastner closed 5 months ago

haimkastner commented 6 months ago

The JS implementation of #31 See also the discussion on angularsen/UnitsNet#1378

Shentoza commented 6 months ago

Any ETA on this PR? Does it have blockers that you could need help with?

haimkastner commented 6 months ago

@Shentoza The PR is ready to be merged.

But as I aim to make it cross-technologies, I'm waiting for the UnitNet C# owner to provide their input before publishing and committing to the new API.

Since I don't know when he will give his input, if it helps, I can publish the new API as a beta release, with no guarantee of slight changes before the final release (unlikely, but still possible)

WDYT?

Shentoza commented 6 months ago

That makes totally sense to wait if the C# package owner agrees to your approach, which would be great. For now i have a working solution™, so it's not urgent, and I will just swap out once this PR completes.

Shentoza commented 6 months ago

since I seem to be the only one interested in this change, i dont think it justifies a beta/bleeding edge branch and for stability reasons, i would wait for the stable release anyway, so i dont have to update twice