Closed Mikejmnez closed 2 years ago
Merging #270 (0bd5abd) into main (0ded3fa) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## main #270 +/- ##
=======================================
Coverage 95.36% 95.36%
=======================================
Files 10 10
Lines 3842 3842
Branches 811 811
=======================================
Hits 3664 3664
Misses 114 114
Partials 64 64
Flag | Coverage Δ | |
---|---|---|
unittests | 95.36% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
CI again builds the testing environment with an older version of matplotlib (version 3.3.2
) than necessary, but that may be related to a compatibility issue unrelated to oceanspy
. In my computer, the oceanspy_test
installs matplotlib version 3.5.2
.
Thanks to @MaceKuailv who figure out that there is an issue with matplotlib version > 3.5.2. See issue #269 for a description. Pinning down allows all tests to pass in my testing environment. It is also the reason the previous PR #268 passed (we looked and the ci/environment used an even older version of matplotlib, which is why all tests passed. We don't know why it used an older matplotlib version though, but that is a separate issue).
This PR also unpins xarray, since tests ran fine within the new
oceanspy_test
environment which does not pin xarray . If there is an issue then we can figure out later, but so far all tests passed on my oceanspy_test environment.Lets see if things go well...