search

hainegroup / oceanspy

A Python package to facilitate ocean model data analysis and visualization.
https://oceanspy.readthedocs.io
MIT License
100 stars 32 forks source link

add combine nested #279

Closed malmans2 closed 1 year ago

malmans2 commented 1 year ago

Closes #274

I think the datasets that are failing are experiencing a breaking change in xarray. We just have to specify combine="nested".

@ThomasHaine looks like you tested with a different environment. I couldn't reproduce the issue using the Oceanography Image on SciServer (I believe that's because that image uses an old version of xarray). Could you please run your script again with this version of the catalog? You just have to specify the catalog url corresponding to this branch:

catalog_url="https://raw.githubusercontent.com/hainegroup/oceanspy/add-combine/sciserver_catalogs/catalog_xarray.yaml"
od = ospy.open_oceandataset.from_catalog(name, catalog_url=catalog_url)

(where name is the name of the catalogue entry, such as IGPwinter)

codecov[bot] commented 1 year ago

Codecov Report

Merging #279 (d359517) into main (a39fb85) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #279   +/-   ##
=======================================
  Coverage   95.11%   95.11%           
=======================================
  Files          10       10           
  Lines        3848     3848           
  Branches      812      812           
=======================================
  Hits         3660     3660           
  Misses        122      122           
  Partials       66       66
Flag Coverage Δ
unittests 95.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more