search

hainegroup / oceanspy

A Python package to facilitate ocean model data analysis and visualization.
https://oceanspy.readthedocs.io
MIT License
98 stars 32 forks source link

pin xesmf < 8.4 #291

Closed Mikejmnez closed 1 year ago

Mikejmnez commented 1 year ago

Description

Just a couple of hours ago, as @malmans2 and I were hoping to get a new oceanspy release, there was a new release of ESMpy, which affected how to import xESMF. The new version (8.4) leads to the following error in oceanspy.subsample which I reproduce by simply just trying to import xesfm on the command line:

fail

The issue and temporal solution can be seen here on (xESMF GH repo):

https://github.com/pangeo-data/xESMF/issues/212

Pinning down esmf < 8.4 (hence installing version 8.3.+) allows all tests to pass. This is a temporal solution to a problem outside of oceanspy.

Espect a PR soon enough...

malmans2 commented 1 year ago

I think you can unpin now: https://github.com/pangeo-data/xESMF/issues/217

Mikejmnez commented 1 year ago

will do so. I was also making some other little changes. PR coming soon!

Mikejmnez commented 1 year ago

closed by #300