hainegroup / oceanspy

A Python package to facilitate ocean model data analysis and visualization.
https://oceanspy.readthedocs.io
MIT License
98 stars 32 forks source link

Fix tarball and wheel #295

Closed ocefpaf closed 1 year ago

ocefpaf commented 1 year ago

Closes #294

CI from before the fix: https://github.com/ocefpaf/oceanspy/actions/runs/3688029568/jobs/6242344958#step:8:74 And after the fix: https://github.com/ocefpaf/oceanspy/actions/runs/3688196116/jobs/6242710952#step:8:71

The wheel is now installable and importable.

codecov[bot] commented 1 year ago

Codecov Report

Merging #295 (fd2ee9a) into main (7cb16ef) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #295   +/-   ##
=======================================
  Coverage   95.25%   95.25%           
=======================================
  Files           9        9           
  Lines        3898     3898           
  Branches      833      833           
=======================================
  Hits         3713     3713           
  Misses        116      116           
  Partials       69       69           
Flag Coverage Δ
unittests 95.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Mikejmnez commented 1 year ago

Thank you @ocefpaf ! I don't fully understand why the docs didn't build, but once they do we can merge this PR.

ocefpaf commented 1 year ago

Thank you @ocefpaf ! I don't fully understand why the docs didn't build, but once they do we can merge this PR.

I don't use readthedocs so I'm clueless on what can I do here to fix it. Their error message seems to be a red herring b/c I can clone the PR using that command.

Mikejmnez commented 1 year ago

I don't use readthedocs so I'm clueless on what can I do here to fix it. Their error message seems to be a red herring b/c I can clone the PR using that command.

Yeah, I agree it's a weird error. I can also clone the repository with the failing command.

I'll approve this PR and if there is an issue later with the documentation, we can always fix it afterwards. I really want to get the new version of oceanspy released

malmans2 commented 1 year ago

Thanks @ocefpaf!